Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dead external links and update make commands in the contributing doc #1617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix dead external links and update make commands in the contributing doc #1617

wants to merge 1 commit into from

Conversation

lunarwhite
Copy link
Contributor

Propose some changes while walking through the documentation site.

  • Updated content/docs/contributing/crds.md with latest commands documented in make/ci.mk.
  • Updated the Kyverno's doc links path.
  • Changed the Garden's example doc reference to the latest one.
  • Removed a Tutorial reference that is no longer accessible.

@cert-manager-prow cert-manager-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Dec 24, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 24, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 24, 2024 •
edited
Loading

✅ Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bbec004
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/676a821ae574a600095788d1
😎 Deploy Preview https://deploy-preview-1617--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lunarwhite
fix or remove dead links
bbec004 
- also update make commands in the contributing doc

Signed-off-by: GitHub <noreply@github.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Dec 24, 2024
@lunarwhite lunarwhite marked this pull request as ready for review December 24, 2024 09:46
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lunarwhite