Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use secure cipher suites for tls by default #380

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Use secure cipher suites for tls by default #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions auth_server/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,7 @@ func ServeOnce(c *server.Config, cf string) (*server.AuthServer, *http.Server) {
glog.Exitf("Failed to create auth server: %s", err)
}

tlsConfig := &tls.Config{
PreferServerCipherSuites: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PreferServerCipherSuites is deprecated and ignored

}
tlsConfig := &tls.Config{}
if c.Server.HSTS {
glog.Info("HTTP Strict Transport Security enabled")
}
Expand Down Expand Up @@ -101,6 +99,10 @@ func ServeOnce(c *server.Config, cf string) (*server.AuthServer, *http.Server) {
}
tlsConfig.CipherSuites = values
glog.Infof("TLS CipherSuites: %s", c.Server.TLSCipherSuites)
} else {
for _, s := range tls.CipherSuites() {
tlsConfig.CipherSuites = append(tlsConfig.CipherSuites, s.ID)
}
}
if c.Server.CertFile != "" || c.Server.KeyFile != "" {
// Check for partial configuration.
Expand Down
Loading