Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking changes changes made in 1.12 and leftovers #383

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

roman-vynar
Copy link
Contributor

Fix breaking changes changes made in 1.12 and leftovers:

  • http_timeout: 10 became http_timeout: "10s" in the samples, otherwise it will be nanoseconds and impossible to do Google auth etc. Nothing mentioned in the changelog.
  • token_db config string became level_token_db.path in the samples. Nothing mentioned in the changelog.
  • Fixed config options checks when level_token_db.path was set but docker_auth still complaining it is not.
  • Replace deprecated ioutil.ReadAll > io.ReadAll

@techknowlogick
Copy link
Collaborator

Thanks for this PR, would you mind resolving the conflicts?

@roman-vynar
Copy link
Contributor Author

@techknowlogick done.

@techknowlogick
Copy link
Collaborator

@roman-vynar much appreciated, thanks!! 😊

@techknowlogick techknowlogick merged commit 69aa630 into cesanta:main Jun 10, 2024
8 checks passed
@orbatschow
Copy link

@techknowlogick could this maybe be released?

As far as I can see, the current Docker image is broken for OIDC usage without these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants