Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Release Workflow #13

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

stanleyzapata
Copy link
Collaborator

@stanleyzapata stanleyzapata commented Nov 21, 2024

Adds new release workflow using the Semantic Release Github Action
Updates Release version on ReadMe on Release

@cesarParra cesarParra self-requested a review November 21, 2024 13:43
@cesarParra cesarParra self-assigned this Nov 21, 2024
@cesarParra cesarParra added the ops Ops or CI Related operation label Nov 21, 2024
preset: "conventionalcommits",
presetConfig: {
types: [
{ type: "feat", section: "✨ Features", hidden: false },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stanleyrad1 Do we need all of these release types? I would think that the only ones that are important for this repo are "feat", and "fix", and maybe "refactor"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean it doesn't hurt to have them, and let's you be more granular. If you notice in the commit-analyzer section, it will create a different type of release depending on how you prefix the commits. The release-notes-generator won't add sections that are not being used, if that's the concern

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah got it. I see in the releaseRules that a lot of these are turned off, that was my main concern. I didn't want a patch version to get created for a lot of these

Copy link
Owner

@cesarParra cesarParra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment

@cesarParra cesarParra merged commit 7dbdeed into cesarParra:main Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ops Ops or CI Related operation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants