Content Baseline Anchors #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfi
reviewed
Aug 15, 2024
src/draw/shapes.typ
Outdated
Comment on lines
858
to
875
| center: bounds-center, | ||
| mid: mid, | ||
| mid-east: mid-east, | ||
| mid-west: mid-west, | ||
| base: base, | ||
| base-east: base-east, | ||
| base-west: base-west, | ||
| north: north, | ||
| north-east: north-east, | ||
| north-west: north-west, | ||
| south: south, | ||
| south-east: south-east, | ||
| south-west: south-west, | ||
| east: east, | ||
| west: west, |
There was a problem hiding this comment.
Very cool to see this added already! As far as can see, this PR currently only adds base-* and mid-* anchors. All that remains to achieve parity with Tikz in this regard is the text anchor, which lies where the contents baseline and western edge meet.
johannes-wolf
force-pushed
the
cetz-683-content-text-bounds
branch
from
8c52968 to
1c0ab22
Compare
fenjalien
reviewed
Aug 15, 2024
fenjalien
reviewed
Aug 23, 2024
johannes-wolf
force-pushed
the
cetz-683-content-text-bounds
branch
2 times, most recently
from
ea491e1 to
f93b479
Compare
|
Was containing the changes for the 0.3 release. I've removed them. |
johannes-wolf
force-pushed
the
cetz-683-content-text-bounds
branch
from
723529e to
13bd796
Compare
fenjalien
approved these changes
Sep 6, 2024
johannes-wolf
force-pushed
the
cetz-683-content-text-bounds
branch
from
13bd796 to
656d465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #683
Lets add this to 0.3.