Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new template for legacy blog/newsroom items #8484

Merged
merged 18 commits into from
Oct 7, 2024

Conversation

csebianlander
Copy link
Contributor

@csebianlander csebianlander commented Jun 24, 2024

This PR creates an indpendent HTML template for Legacy Blog and Legacy Newsroom page types, to allow the template-level addition of an "archived content" banner.

That banner currently exists in rough form with a placeholder URL built out of a (not yet functional) Archive-It URL string and a generated canonical URL for the page rendered by the template. It's not functional but you can still see how it will work in practice once a proper organization account and crawl collection has been established in Archive-It.


How to test this PR

  1. localhost
  2. Create or edit/view a Legacy Blog or Newsroom page

Screenshots

Screenshot 2024-06-24 at 11 48 44 AM

Checklist

  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines
  • Future todos are captured in comments and/or tickets
  • Project documentation has been updated, potentially one or more of:
    • This repo’s docs (edit the files in the /docs folder) – for basic, close-to-the-code docs on working with this repo
    • CFGOV/platform wiki on GHE – for internal CFPB developer guidance
    • CFPB/hubcap wiki on GHE – for internal CFPB design and content guidance

@csebianlander csebianlander self-assigned this Jun 24, 2024
@anselmbradford
Copy link
Member

Some updates:

  • Moved the legacy banner to the correct block.
  • Added a banner template, and made the legacy banner use it.
  • Made the FIG use the banner template and removed the period from the end of the FIG link URL.
  • Made the beta banner use the banner template.

@csebianlander csebianlander marked this pull request as ready for review October 4, 2024 14:47
cfgov/v1/jinja2/v1/includes/molecules/banner.html Outdated Show resolved Hide resolved
cfgov/v1/jinja2/v1/includes/organisms/header.html Outdated Show resolved Hide resolved
cfgov/v1/jinja2/v1/includes/molecules/banner.html Outdated Show resolved Hide resolved
cfgov/v1/jinja2/v1/includes/molecules/banner.html Outdated Show resolved Hide resolved
cfgov/v1/jinja2/v1/blog/legacy_blog_page.html Outdated Show resolved Hide resolved
csebianlander and others added 5 commits October 4, 2024 11:45
Co-authored-by: Andy Chosak <andy.chosak@cfpb.gov>
Co-authored-by: Andy Chosak <andy.chosak@cfpb.gov>
Co-authored-by: Andy Chosak <andy.chosak@cfpb.gov>
Co-authored-by: Andy Chosak <andy.chosak@cfpb.gov>
@csebianlander csebianlander added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit b787e51 Oct 7, 2024
12 checks passed
@csebianlander csebianlander deleted the legacy-page-template branch October 7, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants