Skip to content

Conversation

@itsmedavep
Copy link
Contributor

Also updated

label-helper to use CSS custom properties

Additions

Removals

Changes

Testing

  1. Built project
  2. Verfied no visual regressions

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the CFPB development guidelines
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Browsers

  • Chrome on desktop
  • Firefox
  • Safari on macOS
  • Edge
  • Safari on iOS
  • Chrome on Android

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@anselmbradford anselmbradford changed the title JSON: cfpb-lable updated import to use translated JSON JSON: cfpb-label updated import to use translated JSON Dec 10, 2025
&__helper {
color: $label-helper;
color: var(--label-helper);
font-size: math.div(16px, $base-font-size-px) + rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose moving $base-font-size-px to a variable would be a good idea, since we use it everywhere. (Not in this PR though.)

Also updated

label-helper to use CSS custom properties
@itsmedavep itsmedavep force-pushed the dave_rewire_cfpb_label_component_to_use_css_translated_JSON branch from 9efa9a1 to 82ff8d2 Compare December 12, 2025 19:54
@itsmedavep itsmedavep merged commit a995053 into main Dec 12, 2025
3 checks passed
@itsmedavep itsmedavep deleted the dave_rewire_cfpb_label_component_to_use_css_translated_JSON branch December 12, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants