Skip to content

Conversation

@itsmedavep
Copy link
Contributor

Updated @use to point at src/elements/abstracts

I did NOT change the utilities import because we are not duplicating that into the web components currently Same thing goes for the icons. We currently are not duplicating them into elements so I did not update that import

[Short description explaining the high-level reason for the pull request]

Additions

Removals

Changes

Testing

  1. Built project
  2. Verified there were no visual regressions

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the CFPB development guidelines
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Browsers

  • Chrome on desktop
  • Firefox
  • Safari on macOS
  • Edge
  • Safari on iOS
  • Chrome on Android

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Updated @use to point at src/elements/abstracts

I did NOT change the utilities import because we are not duplicating that into the web components currently
Same thing goes for the icons. We currently are not duplicating them into elements so I did not update that import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants