Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] 2019/9/29 #480

Merged
merged 29 commits into from
Sep 30, 2019
Merged

[sync] 2019/9/29 #480

merged 29 commits into from
Sep 30, 2019

Conversation

Vadaski
Copy link
Member

@Vadaski Vadaski commented Sep 29, 2019

No description provided.

maguinis and others added 20 commits September 23, 2019 13:49
To reduce expectations on desktop support.
Added a go-link for `go/web-plugins-layout` where we discuss where exactly to put web plugins
TextFormField now also support OnChanged callback according to flutter/flutter#28914
* Showcase Redesing  (#2)

[b/141305122] Showcase redesign.

What's included?
- New showcase page.
- Cleanup styles and assets from the previous version.

* Showcase optimizations.

[b/141305122] Showcase redesign.

What's included?
- Optimize carousel SVG background texture.
- Optimize logos.
Also deleted some obsolete comments about removing a page from wiki.
* Adding FFI info

* Adding more info to the "what's new" section.

* Fixing broken links.

* Reformatting ffi page and clarifying.

* Reworking page as per current wiki page.

* Tweaking TOC

* Incorporating feedback.
* Added dartpad but with old examples from dart.dev

* Updated dartpad to flutter mode + light theme

* Refactor to counter example

* Added 3 working examples, added dartpad to install page

* Add an include in index

* Add style and language updates to /docs/get-started/install:

- Reframe the installation page as the very first step of get started (aka try/install)
- Put the embedded Dartpad above the installation buttons and change the page title.
- Update title in left nav

* Minor updates/corrections

* Fix broken link for chrome os

* Add styling tweak to dartpad section on landing page

* Use 'Install Flutter' on landing page

* Fix typo

* Rebuild dartpad_picker

* Remove warning about Chrome 77

* Left-align headings on install page

* Remove changes to install page

* Remove changes to sidenav for install page
In the ByteDance section
* Lock CocoaPods version to 1.7.5

* Shams feedback
@Vadaski
Copy link
Member Author

Vadaski commented Sep 29, 2019

ref:#374

Copy link
Member

@chenglu chenglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要针对我提到的内容进行修正。

_config.yml Outdated Show resolved Hide resolved
src/_includes/banner.html Outdated Show resolved Hide resolved
src/docs/development/tools/sdk/upgrading.md Show resolved Hide resolved
src/docs/development/ui/layout/responsive.md Show resolved Hide resolved
Fixed "video" styling error, and translated the updated docs.
@chenglu
Copy link
Member

chenglu commented Sep 30, 2019

所有文件我都 review 过了,可以修改一下了。
如果在本地修改不直观,直接在线上修改也可以 @Vadaski
Thanks!

添加翻译
@Vadaski
Copy link
Member Author

Vadaski commented Sep 30, 2019

好的!我发现我一直以来的维护流程有问题,只处理了冲突部分,Sorry!
我再重新检查一遍。

@Vadaski
Copy link
Member Author

Vadaski commented Sep 30, 2019

已知问题处理完毕

Copy link
Member

@chenglu chenglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chenglu chenglu merged commit 09e21e3 into cfug:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.