Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: NavTitle display update, _isHiddenOnMenu support (fixes #12) #13

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Fix: NavTitle display update, _isHiddenOnMenu support (fixes #12) #13

merged 3 commits into from
Jan 30, 2024

Conversation

guywillis
Copy link
Contributor

Fixes #12

Fix

  • Adds _isHiddenOnMenu option to hide the title on the main menu (in course.json)
  • Content objects will inherit title values from course.json
  • Removes version number from README.md

@guywillis guywillis added the bug label Jan 26, 2024
@guywillis guywillis self-assigned this Jan 26, 2024
kirsty-hames
kirsty-hames reviewed Jan 29, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
kirsty-hames
kirsty-hames approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks @guywillis.

swashbuck
swashbuck approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guywillis guywillis merged commit c5c77b2 into master Jan 30, 2024
@guywillis guywillis deleted the issue/12 branch January 30, 2024 09:28
github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
@semantic-release-bot
Chore(release): 1.0.3 [skip ci]
17f41f7 
## [1.0.3](v1.0.2...v1.0.3) (2024-01-30)

### Fix

* NavTitle display update, _isHiddenOnMenu support (fixes #12) (#13) ([c5c77b2](c5c77b2)), closes [#12](#12) [#13](#13)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@guywillis guywillis

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to display nav title for menu or page only
3 participants
@guywillis @swashbuck @kirsty-hames