Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Moved JS logic into template jsx (fixes #14) #15

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Fix: Moved JS logic into template jsx (fixes #14) #15

merged 5 commits into from
Jul 15, 2024

Conversation

guywillis
Copy link
Contributor

Fixes: #14

Fix

  • Moved title display and show / hide mobile logic into template JSX
  • Typo fix in contentObject schema

@guywillis guywillis added the bug Something isn't working label Jul 4, 2024
@guywillis guywillis self-assigned this Jul 4, 2024
@guywillis guywillis requested a review from swashbuck July 15, 2024 14:15
swashbuck
swashbuck approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swashbuck swashbuck merged commit e60fc64 into master Jul 15, 2024
@swashbuck swashbuck deleted the issue/14 branch July 15, 2024 22:07
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@swashbuck swashbuck swashbuck approved these changes

@kirsty-hames kirsty-hames Awaiting requested review from kirsty-hames

Assignees

@guywillis guywillis

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move title display / mobile hide logic into template
3 participants
@guywillis @swashbuck @oliverfoster