Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty cache before we run folding #47

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Empty cache before we run folding #47

merged 5 commits into from
Sep 13, 2024

Conversation

wukevin
Copy link
Contributor

@wukevin wukevin commented Sep 13, 2024

Description

More aggressively removes things from memory and clear cache.

Motivation

Seeing OOMs in a lot of places where we wouldn't expect them to happen:

  • feature_embedding.forward
  • rank

This more aggressively deletes weights from GPU and does ranking on CPU.

Test plan

Works locally, outputs look as expected.

@jackdent jackdent merged commit 1d3e499 into main Sep 13, 2024
4 checks passed
@jackdent jackdent deleted the kevin/cuda-clear-cache branch September 13, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants