Skip to content

Enable no-var rule and fix violations #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2025
Merged

Enable no-var rule and fix violations #1675

merged 2 commits into from
Feb 23, 2025

Conversation

koddsson
Copy link
Member

Lets enforce more modern JavaScript.

See https://eslint.org/docs/latest/rules/no-var

@koddsson koddsson requested a review from a team as a code owner February 23, 2025 12:14
@koddsson koddsson enabled auto-merge (squash) February 23, 2025 12:15
43081j
43081j approved these changes Feb 23, 2025
View reviewed changes
Copy link
Contributor

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good but i suspect a whole bunch of these could be const. is that true?

maybe we should also enable prefer-const (i don't quite remember if that's the rule name) and auto-fix them

@koddsson koddsson merged commit 9d22af3 into chaijs:main Feb 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@43081j 43081j 43081j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koddsson @43081j