Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working devnet #8

Merged
merged 23 commits into from
Oct 17, 2024
Merged

working devnet #8

merged 23 commits into from
Oct 17, 2024

Conversation

namn-grg
Copy link

@namn-grg namn-grg commented Oct 3, 2024

This PR contains Kurtosis devnet integration errors.

@namn-grg namn-grg changed the title fix: devnet fixes by lore fix: working devnet Oct 3, 2024
@namn-grg namn-grg changed the title fix: working devnet working devnet Oct 3, 2024
@namn-grg namn-grg marked this pull request as draft October 3, 2024 15:33
@merklefruit merklefruit marked this pull request as ready for review October 9, 2024 16:28
@chainbound chainbound deleted a comment from coderabbitai bot Oct 10, 2024
Copy link
Collaborator

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Comment on lines +48 to +59
let mut builder_infos = db.get_all_builder_infos().await.expect("failed to load builder infos");

builder_infos.push(BuilderInfoDocument {
pub_key: PublicKey::try_from(
Bytes::from_hex("0xaa1488eae4b06a1fff840a2b6db167afc520758dc2c8af0dfb57037954df3431b747e2f900fe8805f05d635e9a29717b").unwrap().as_ref()
).expect("failed to convert to public key"),
builder_info: BuilderInfo {
collateral: U256::MAX / U256::from(4),
is_optimistic: true,
builder_id: Some("Bolt".to_string())
}
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently hardcoded to avoid inserting builders manually each time we start the devnet via an SQL query. A configuration-based approach is explored in this PR: gattaca-com#41. For now we can keep it as it this and change it later.

crates/common/src/proofs.rs Outdated Show resolved Hide resolved
crates/database/src/postgres/migrations/V1__initial.sql Outdated Show resolved Hide resolved
crates/housekeeper/src/chain_event_updater.rs Outdated Show resolved Hide resolved
crates/housekeeper/src/chain_event_updater.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits!

crates/api/src/constraints/api.rs Show resolved Hide resolved
crates/api/src/constraints/api.rs Outdated Show resolved Hide resolved
crates/api/src/constraints/api.rs Outdated Show resolved Hide resolved
crates/common/src/proofs.rs Show resolved Hide resolved
@thedevbirb thedevbirb merged commit 5898d70 into naman/feat/constraints-api-new Oct 17, 2024
1 check passed
@thedevbirb thedevbirb deleted the naman/devnet branch October 17, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants