Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reqrep compression #66

Merged
merged 5 commits into from
Jan 26, 2024
Merged

feat: reqrep compression #66

merged 5 commits into from
Jan 26, 2024

Conversation

merklefruit
Copy link
Contributor

@merklefruit merklefruit commented Jan 22, 2024 •
edited
Loading

Req/Rep Compression

Tasks
Beta Give feedback

@merklefruit merklefruit self-assigned this Jan 22, 2024
@merklefruit merklefruit added C-feature Category: Feature A-wire Area: Wire protocol A-compression Area: Compression S-breaking Status: Contains breaking changes labels Jan 22, 2024
@merklefruit merklefruit changed the title feat: reqrep compression (request only) feat: reqrep compression Jan 23, 2024
@merklefruit merklefruit marked this pull request as ready for review January 23, 2024 12:47
mempirate
mempirate requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is looking good, would only add a simple test with compression on both req and rep socket

mempirate
mempirate approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mempirate mempirate merged commit 7d7f6dc into main Jan 26, 2024
8 checks passed
@mempirate mempirate deleted the feat/reqrep/compression branch January 26, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mempirate mempirate mempirate approved these changes

Assignees

@merklefruit merklefruit

Labels
A-compression Area: Compression A-wire Area: Wire protocol C-feature Category: Feature S-breaking Status: Contains breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(reqrep): Add compression
2 participants
@merklefruit @mempirate