Split publishing and loading #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjohnsonjr
force-pushed
the
avi-followup
branch
from
7e63c98
to
d21c82b
Compare
|
I like the idea of decoupling. The question is, should we do it even one step further? Maybe it shouldn't be |
|
I'd prefer having a separate |
jonjohnsonjr
force-pushed
the
avi-followup
branch
from
d21c82b
to
5e40284
Compare
This untangles daemon from remote when publishing a bit more, which will make it easier to move towards lazily producing these images, which will make it easier to avoid building things entirely. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
jonjohnsonjr
force-pushed
the
avi-followup
branch
from
5e40284
to
a590e36
Compare
imjasonh
approved these changes
Jul 19, 2023
imjasonh
approved these changes
Jul 19, 2023
markkrj
reviewed
Jan 19, 2024
| if err != nil { | ||
| return name.Digest{}, err | ||
| } | ||
| if strings.HasPrefix(localSrcTag.Name(), fmt.Sprintf("%s/", LocalDomain)) { |
There was a problem hiding this comment.
Will not this always be true? Line 97 has localSrcTagStr := fmt.Sprintf("%s/%s:%s", LocalDomain...
I was expecting that publish myimage.yaml myimage:mytag --local actually loaded the tags to my Docker daemon. This prevents it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This untangles daemon from remote when publishing a bit more, which will make it easier to move towards lazily producing these images, which will make it easier to avoid building things entirely.