Conversation
Signed-off-by: s-stumbo <sally.stumbo@chainguard.dev>
✅ Deploy Preview for ornate-narwhal-088216 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
I dont think we should do this change at all.
| the environment variables are set, the following steps configure registry | ||
| detailed in the [access documentation](/chainguard/libraries/access/#env). For | ||
| production use, set the config URL to either your organization's artifact | ||
| manager alreaady in use, or directly to `libraries.cgr.dev/javascript`. Once the |
There was a problem hiding this comment.
Tis is wrong .. the correct URL requires a / at the end and its actually documented right below. And we should not suggest direct access for production use inconsistently.
There was a problem hiding this comment.
@mosabua we are suggesting direct access as a way to use the chainguard repository with the upstream fallback option.
There was a problem hiding this comment.
Thanks for calling out the missing slash, I added that to the URL in this paragraph
There was a problem hiding this comment.
Chainguard Repository use and suggestion to use direct access are unrelated and should not be mixed up. If you make that change here you should make it everywhere for all the client tools .. as it stands this seems wrong. cc @angela-zhang
Signed-off-by: s-stumbo <sally.stumbo@chainguard.dev>
4 participants
[X] Check if this is a typo or other quick fix and ignore the rest :)
Type of change
What should this PR do?
Under JavaScript Build Configuration > npm > Minimal example project,
changed this
to this