Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make locking packages an error #198

Closed
wants to merge 2 commits into from
Closed

Conversation

imjasonh
Copy link
Member

Seems one was missed in #119

Kudos to @jonjohnsonjr for finding it

Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh requested a review from mattmoor November 15, 2023 17:11
@imjasonh
Copy link
Member Author

@mattmoor was this a warning on purpose?

diag.NewWarningDiagnostic("unable to lock certain packages for amd64", "[intel-fast-as-f-math]"),
diag.NewWarningDiagnostic("unable to lock certain packages for arm64", "[arm-energy-efficient-as-f-arithmetic]"),
diag.NewErrorDiagnostic("unable to lock certain packages for amd64", "[intel-fast-as-f-math]"),
diag.NewErrorDiagnostic("unable to lock certain packages for arm64", "[arm-energy-efficient-as-f-arithmetic]"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were intended as examples where we legitimately shouldn't fail because it is actually impossible to create a platform-independent lock file.

@imjasonh imjasonh closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants