👷 ci: Verify lockfile in case commit-lockfile is false #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogFlames
force-pushed
the
880-github-action-doesnt-fail-on-invalid-lockfile
branch
2 times, most recently
from
16e668f to
bfc8af4
Compare
LogFlames
force-pushed
the
880-github-action-doesnt-fail-on-invalid-lockfile
branch
from
bfc8af4 to
d4032a2
Compare
LogFlames
deleted the
880-github-action-doesnt-fail-on-invalid-lockfile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
commit-lockfileis false it will verify the lockfile instead of commiting a new one. Previously if you setcommit-lockfileand only wanted it to check the lockfile, in case the pom.xml had updated. It would create the new lockfile, not commit it, and then successfully finish the action.It now allways runs the verify in case commit-lockfile is false, if commit-lockfile is true it will verify if pom is same and update/commit if pom has changed.
Added documentation in the README.md for the action parameters.