💚 fix ci: Fix erroneous indentation in action.yml #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogFlames
force-pushed
the
1032-release-action-tries-to-update-lockfile-in-main-in-pom-is-changed
branch
from
1f69d31 to
c0d63a9
Compare
LogFlames
force-pushed
the
1032-release-action-tries-to-update-lockfile-in-main-in-pom-is-changed
branch
from
c0d63a9 to
c0176dd
Compare
|
The journey continues, action.yml was broken for these releases. Lets hope for 5.3.5 :) I want to find a better way to work on CI issues without having to create this many releases. |
LogFlames
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a journey. Because of an update to quarkus the CI now requires Java 17 in the github aciton. Do note that the maven plugin is still compiled and works with Java 11.
Because the action needed to be updated a release was required before the new version could be used. Unfortunately some releases (e.g. 5.3.0) will not work in CI since quarkus was automatically updated and no CI test caught that it required Java 17, thus merging it and it went with the 5.3.0 release while it still used Java 11 in the action.yml.