Remove revm-inspectors js-tracer dependencies #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
ercecan,
eyusufatik,
jfldde,
kpp and
rakanalh
kpp
approved these changes
Aug 23, 2024
eyusufatik
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reth-rpc-eth-types 1.0.4 dependency was importing the revm-inspectors with the js-tracer enabled by default, which caused javascript engine boa_engine dependency and its related dependencies to be included in our codebase unnecessarily. The js-tracer is feature gated in version 1.0.5 of reth, but the problem was that it requires rust version 1.80, which is not supported by risc0 yet. Hence, I hand picked the reth commit that has rust version 1.79, but has the js-tracer feature gated.
Linked Issues