Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl guest side verification #1375

Open
wants to merge 4 commits into
base: nightly
Choose a base branch
from
Open

Impl guest side verification #1375

wants to merge 4 commits into from

Conversation

ercecan
Copy link
Member

@ercecan ercecan commented Oct 24, 2024

Description

MERGE AFTER #1336
Initial pr that prepares the foundation for #1306
After merged, for testing Risc0's FakeReceipts will be used with RISC0_DEV_MODE enabled

Linked Issues

@ercecan ercecan added the HOLD-MERGE PR is not draft but should not be merged yet label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 28 lines in your changes missing coverage. Please review.

Project coverage is 78.3%. Comparing base (978ca6f) to head (b2351cc).
Report is 4 commits behind head on nightly.

Files with missing lines Patch % Lines
...ates/sovereign-sdk/adapters/risc0/src/guest/mod.rs 0.0% 15 Missing ⚠️
crates/risc0-bonsai/src/host.rs 26.6% 11 Missing ⚠️
crates/sovereign-sdk/adapters/mock-zkvm/src/lib.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...n-sdk/rollup-interface/src/state_machine/zk/mod.rs 100.0% <ø> (ø)
crates/sovereign-sdk/adapters/mock-zkvm/src/lib.rs 63.6% <0.0%> (-0.9%) ⬇️
crates/risc0-bonsai/src/host.rs 17.0% <26.6%> (-0.5%) ⬇️
...ates/sovereign-sdk/adapters/risc0/src/guest/mod.rs 0.0% <0.0%> (ø)

... and 21 files with indirect coverage changes

@ercecan ercecan removed the HOLD-MERGE PR is not draft but should not be merged yet label Oct 25, 2024
}

fn extract_output<Da: sov_rollup_interface::da::DaSpec, Root: BorshDeserialize>(
proof: &Proof,
) -> Result<sov_rollup_interface::zk::StateTransition<Da, Root>, Self::Error> {
match proof {
sov_rollup_interface::zk::Proof::PublicInput(pub_input) => {
sov_rollup_interface::zk::Proof::Mock(pub_input) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call this fake receipt or test receipt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants