Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify chunked txs #1618

Merged
merged 90 commits into from
Jan 10, 2025
Merged

Verify chunked txs #1618

merged 90 commits into from
Jan 10, 2025

Conversation

rakanalh
Copy link
Contributor

Description

Linked Issues

eyusufatik
eyusufatik requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@eyusufatik eyusufatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to implement

BitcoinService::extract_relevant_blobs_with_proof line 993

and BitcoinVerifier::verify_transactions line 153

crates/light-client-prover/src/circuit.rs Outdated Show resolved Hide resolved
crates/light-client-prover/src/circuit.rs Outdated Show resolved Hide resolved
crates/sovereign-sdk/rollup-interface/src/state_machine/zk/mod.rs Outdated Show resolved Hide resolved
crates/light-client-prover/src/da_block_handler.rs Outdated Show resolved Hide resolved
@eyusufatik eyusufatik requested a review from kpp December 17, 2024 15:18
@rakanalh rakanalh marked this pull request as ready for review December 20, 2024 08:23
@auto-assign auto-assign bot requested a review from yaziciahmet December 20, 2024 08:23
eyusufatik
eyusufatik requested changes Dec 20, 2024
View reviewed changes
crates/sovereign-sdk/rollup-interface/src/state_machine/zk/mod.rs Outdated Show resolved Hide resolved
crates/bitcoin-da/src/verifier.rs Outdated Show resolved Hide resolved
crates/light-client-prover/src/circuit.rs Outdated Show resolved Hide resolved
@eyusufatik
Copy link
Member

eyusufatik commented Jan 8, 2025 •
edited
Loading

waiting on @ercecan to write tests for the pr, hence the hold merge label

@eyusufatik eyusufatik merged commit 775635c into nightly Jan 10, 2025
14 of 15 checks passed
@eyusufatik eyusufatik deleted the rakanalh/verify-chunked-txs branch January 10, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaziciahmet yaziciahmet yaziciahmet left review comments

@kpp kpp kpp left review comments

@ercecan ercecan ercecan approved these changes

@eyusufatik eyusufatik eyusufatik approved these changes

@jfldde jfldde Awaiting requested review from jfldde

Assignees

@rakanalh rakanalh

Labels
HOLD-MERGE PR is not draft but should not be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Light client proof verify chunked txs
6 participants
@rakanalh @yaziciahmet @eyusufatik @kpp @ercecan @jfldde