Skip to content

Implement FromEnv for MonitoringConfig #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2025
Merged

Implement FromEnv for MonitoringConfig #1697

merged 4 commits into from
Jan 13, 2025

Conversation

jfldde
Copy link
Contributor

@jfldde jfldde commented Jan 13, 2025

Description

  • Implement FromEnv for MonitoringConfig
  • Add support for partial parsing with serde defaults

Fixes #1696

@jfldde jfldde requested a review from eyusufatik as a code owner January 13, 2025 09:29
@auto-assign auto-assign bot requested a review from rakanalh January 13, 2025 09:30
@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.17647% with 20 lines in your changes missing coverage. Please review.

Project coverage is 77.6%. Comparing base (f442a88) to head (e3cdeed).
Report is 1 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/bitcoin-da/src/monitoring.rs 42.4% 19 Missing ⚠️
crates/bitcoin-da/src/service.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/bitcoin-da/src/service.rs 75.2% <0.0%> (+0.4%) ⬆️
crates/bitcoin-da/src/monitoring.rs 39.3% <42.4%> (-1.3%) ⬇️

... and 5 files with indirect coverage changes

rakanalh
rakanalh approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eyusufatik
eyusufatik previously requested changes Jan 13, 2025
View reviewed changes
@jfldde jfldde requested a review from eyusufatik January 13, 2025 18:04
@jfldde jfldde merged commit 36b26da into nightly Jan 13, 2025
14 of 15 checks passed
@jfldde jfldde deleted the monitoring-config-from-env branch January 13, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakanalh rakanalh rakanalh approved these changes

@eyusufatik eyusufatik eyusufatik approved these changes

Assignees

@jfldde jfldde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make MonitoringConfig optional under BitcoinDaServiceConfig
3 participants
@jfldde @rakanalh @eyusufatik