Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first l2 block copy blocks, transactions, receipts to rlp acessory state #1700

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

eyusufatik
Copy link
Member

@eyusufatik eyusufatik commented Jan 13, 2025

we tried to avoid implementing this but here we are.

only affects native execution so don't worry about the cycles.

still needs DoNot.... structs to convert stuff just like we did with head and head_rlp

eyusufatik and others added 2 commits January 13, 2025 16:07
Co-authored-by: eyusufatik <esadyusufatik@gmail.com>
@eyusufatik eyusufatik self-assigned this Jan 13, 2025
@eyusufatik eyusufatik marked this pull request as ready for review January 13, 2025 18:39
@auto-assign auto-assign bot requested a review from ercecan January 13, 2025 18:39
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 17.61658% with 159 lines in your changes missing coverage. Please review.

Project coverage is 77.3%. Comparing base (f442a88) to head (3515bcc).
Report is 3 commits behind head on nightly.

Files with missing lines Patch % Lines
crates/evm/src/evm/compat.rs 0.0% 138 Missing ⚠️
crates/evm/src/evm/primitive_types.rs 0.0% 16 Missing ⚠️
crates/evm/src/query.rs 89.1% 4 Missing ⚠️
crates/evm/src/provider_functions.rs 50.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/evm/src/evm/mod.rs 64.2% <ø> (ø)
crates/evm/src/hooks.rs 66.6% <ø> (ø)
crates/evm/src/lib.rs 89.4% <ø> (ø)
crates/evm/src/provider_functions.rs 74.0% <50.0%> (+21.4%) ⬆️
crates/evm/src/query.rs 88.4% <89.1%> (+0.8%) ⬆️
crates/evm/src/evm/primitive_types.rs 82.6% <0.0%> (-6.8%) ⬇️
crates/evm/src/evm/compat.rs 0.0% <0.0%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to think about how to do migrations on the native DB in a better way.

@eyusufatik eyusufatik merged commit c151558 into nightly Jan 13, 2025
14 of 15 checks passed
@eyusufatik eyusufatik deleted the esad/accessory-state-migration branch January 13, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants