-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor rollup initialization #1714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left my initial comments, will need to read rollup/mod.rs a bit more in detail.
- L1BlockHandler for all node types has been moved - RPC server is started for batch prover Remaining: - Update spawning RPC server for sequencer / light client
This consistently calls `build_services` which return all services that a specific node would need to spawn using the task manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I also agree on @jfldde comment for Storage struct to hold optional mmrdb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this doesn't break anything. please launch different type of nodes on testnet on your computer. and look out for logs.
I ran both full node & batch prover, they are both syncing without issues.
Batch Prover:
|
Description
Problem we have right now is that config along with a lot of other dependencies go through
main -> rollup -> client (sequencer, fullnode ..etc) -> da_block_handler
So introducing a component in DA block handler that requires a piece of config or a dependency as an example, would require updating the whole flow all the way to that point.
This PR changes this by running RPC & DA block handler as services along side the client (sequencer, fullnode ..etc) not from within. This makes initialization much easier.
What's been done?
common
The above makes it easier to pass configs / dependencies towards fullnode's L1 block handler or RPC without having those configs / dependencies go through the runner.
TODO