Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate ledgerdb tables #1729

Merged
merged 11 commits into from
Jan 23, 2025
Merged

Separate ledgerdb tables #1729

merged 11 commits into from
Jan 23, 2025

Conversation

ercecan
Copy link
Member

@ercecan ercecan commented Jan 21, 2025

Description

Implements separate ledger db tables for nodes so in the future migrations are easied and made only for nodes that involve them

Linked Issues

Testing

Tested all nodes manually by first spinning up nodes on 0.6.1 and then on this branch, did not encounter any errors

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 47.55245% with 75 lines in your changes missing coverage. Please review.

Project coverage is 77.0%. Comparing base (e7185d2) to head (ac81c8f).
Report is 1 commits behind head on nightly.

Files with missing lines Patch % Lines
...r/src/db_migrations/remove_unused_common_tables.rs 0.0% 18 Missing ⚠️
...r/src/db_migrations/remove_unused_common_tables.rs 16.6% 15 Missing ⚠️
...e/src/db_migrations/remove_unused_common_tables.rs 16.6% 15 Missing ⚠️
...r/src/db_migrations/remove_unused_common_tables.rs 16.6% 15 Missing ⚠️
bin/citrea/src/rollup/mod.rs 74.4% 11 Missing ⚠️
...rates/light-client-prover/src/db_migrations/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/batch-prover/src/db_migrations/mod.rs 100.0% <100.0%> (ø)
crates/fullnode/src/db_migrations/mod.rs 100.0% <100.0%> (ø)
crates/sequencer/src/db_migrations/mod.rs 100.0% <100.0%> (ø)
...ull-node/db/sov-db/src/ledger_db/migrations/mod.rs 98.1% <100.0%> (+0.1%) ⬆️
...ign-sdk/full-node/db/sov-db/src/ledger_db/tests.rs 98.9% <100.0%> (+<0.1%) ⬆️
...reign-sdk/full-node/db/sov-db/src/schema/tables.rs 91.5% <ø> (ø)
...rates/light-client-prover/src/db_migrations/mod.rs 0.0% <0.0%> (ø)
bin/citrea/src/rollup/mod.rs 74.7% <74.4%> (-0.1%) ⬇️
...r/src/db_migrations/remove_unused_common_tables.rs 16.6% <16.6%> (ø)
...e/src/db_migrations/remove_unused_common_tables.rs 16.6% <16.6%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

@ercecan ercecan requested a review from jfldde January 21, 2025 13:55
@eyusufatik eyusufatik merged commit dc8917c into nightly Jan 23, 2025
14 of 15 checks passed
@eyusufatik eyusufatik deleted the erce/sparate-ledgerdb-tables branch January 23, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate ledger db tables for nodes
4 participants