Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move withdrawal code to grpc (payout tx creator) and enable withdrawal tests #505

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

Move withdrawal code to grpc (payout tx creator) and enable withdrawal tests #505

wants to merge 19 commits into from
+825 −751

Conversation

ceyhunsen
Copy link
Member

@ceyhunsen ceyhunsen commented Feb 6, 2025 •
edited
Loading

Description

  • Uncomments operator withdrawal code
  • Implements operator::new_withdrawal_sig rpc call
  • Implements payout tx creator

Extras

  • Creates clients in create_actor and returns them instead
  • Uncomments tests::run_single_deposit
  • Fixes compilation errors in rcp::honest_operator_takes_refund test

Linked Issues

@ceyhunsen ceyhunsen changed the title Move withdrawal code to grpc Move withdrawal code to grpc (payout tx creator) and enable withdrawal tests Feb 6, 2025
@ceyhunsen ceyhunsen force-pushed the ceyhun/withdrawal_with_grpc branch from 0d139d4 to 95fc4e2 Compare February 6, 2025 20:00
@ceyhunsen ceyhunsen marked this pull request as ready for review February 7, 2025 07:37
atacann
atacann reviewed Feb 7, 2025
View reviewed changes
Copy link

@atacann atacann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/src/builder/script.rs Outdated Show resolved Hide resolved
mmtftr
mmtftr requested changes Feb 7, 2025
View reviewed changes
core/src/rpc/operator.rs Outdated Show resolved Hide resolved
core/src/test_utils.rs
.add_input(
NormalSignatureKind::NotStored,
txin,
SpendPath::Unknown,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will fail when signing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atacann atacann atacann left review comments

@mmtftr mmtftr mmtftr requested changes

@ekrembal ekrembal Awaiting requested review from ekrembal

@ozankaymak ozankaymak Awaiting requested review from ozankaymak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ceyhunsen @mmtftr @atacann