Save signatures with more information to db #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ath is used during txhandler creation, and to store txin type while storing signature to db Co-authored-by: Mehmet Efe Akça <mmtftr@users.noreply.github.com>
Co-authored-by: Mehmet Efe Akça <mmtftr@users.noreply.github.com>
ceyhunsen
approved these changes
Feb 6, 2025
Yes NormalSignature is not descriptive enough. In this case NormalSignature can include both operator and NofN sigs. It means that there is only one signature per one kickoff, but the other type (WatchtowerSignature) has sigs for each watchtower so they need an additional watchtower_idx parameter. |
|
Will rename to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-While creating TxHandler add information about spend path of input (keypath or script path idx), tag every input with an enum so that we can easily understand which saved nofn signature corresponds to which utxo.
-Save signatures with their tag to db, each row in signatures db is denoted by deposit_outpoint (converted to a unique int), operator_idx, sequential_collateral_idx and kickoff_idx.
Linked Issues