Use external nlohmann-json library instead of copying the files in th… #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For #74 |
greenscientist
force-pushed
the
74jsonlib
branch
from
ad30d7c to
28071a8
Compare
…e project Distro have packages for the json library that we use. Instead of having to maintain a local file in the repo, we will rely on external files on the system. We changed the #include reference to point the the standard files and added a check in the configure to make sure the file is available. Also updated the github actions to install the right packages and updated the README to add the package to the install instructions
greenscientist
force-pushed
the
74jsonlib
branch
from
28071a8 to
1abc769
Compare
kaligrafy
approved these changes
Nov 27, 2023
|
Thanks! looks good, but what happens with Docker? |
|
@tahini , I think it was a sync issue. I had a few failure, but the latest build passed correctly when you check docker hub directly. |
|
PR on the Transition side to also update to bookworm: chairemobilite/transition#781 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e project
Distro have packages for the json library that we use. Instead of having to maintain a local file in the repo, we will rely on external files on the system.
We changed the #include reference to point the the standard files and added a check in the configure to make sure the file is available.
Also updated the github actions to install the right packages and updated the README to add the package to the install instructions