Fix build for macos #292
Merged
Fix build for macos #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenscientist
force-pushed
the
fixmacosbuild
branch
3 times, most recently
from
6e59bdd to
833747d
Compare
tahini
reviewed
Apr 30, 2024
There was a problem hiding this comment.
Je vais laisser @kaligrafy tester pour voir si ça fonctionne aussi sur sa machine.
Par contre, on voit beaucoup de changements dans les fichiers m4, j'imagine que tu n'as pas manuellement fait chacun de ces changements? Si non, serait-il possible de dire dans le commit message comment ils ont été générés?
greenscientist
force-pushed
the
fixmacosbuild
branch
from
833747d to
82e9848
Compare
|
@tahini , J'ai ajouté une mention dans le commit message pour redire que les fichiers sont syncé de l'autoconf-archive. |
kaligrafy
requested changes
Apr 30, 2024
The homebrew location for boost have changed, it's not in the default search path anymore. We add the BOOST_CPPFLAGS to our CPPFLAGS and we update all extra autoconf macro to have the latest update from the autoconf-archive. The boost packages are updated to search boost in /opt/homebrew (the update to ax_cxx_compile for C++20 is also included while at it) Also remove an old comment that should have been removed before in the build workflow
greenscientist
force-pushed
the
fixmacosbuild
branch
from
82e9848 to
12f67b6
Compare
kaligrafy
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The homebrew location for boost have changed, it's not in the default search path anymore.
We add the BOOST_CPPFLAGS to our CPPFLAGS
and we update all extra autoconf macro to have the latest update, which search boost in /opt/homebrew
(the update to ax_cxx_compile is also include while at it)
Also remove an old comment that should have been removed before in the build workflow