Check for index in path node list when parsing connection #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaligrafy
requested changes
Jun 11, 2024
| @@ -116,7 +117,10 @@ namespace TrRouting | |||
| )); | |||
|
|
|||
| trip.connectionDepartureTimes[nodeTimeI] = departureTimesSeconds[nodeTimeI]; | |||
|
|
|||
| } catch (std::out_of_range const& exc) { | |||
| spdlog::error("Index out of range will parsing connection for trip on line ({})", path.line.longname); | |||
We had an issue when the data got corrupted and the number of entry in the path was not the same as in the schedule. This was corrupting the memory. We use the at() instead of [] when accessing the vector in the parsing loop in getSchedules() and we display a meaningful error message if we get the exceptiono
greenscientist
force-pushed
the
indexexceptiontrips
branch
from
6280959 to
721b65c
Compare
tahini
approved these changes
Jun 11, 2024
kaligrafy
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue when the data got corrupted and the number of entry in the path was not the same as in the schedule. This was corrupting the memory. We use the at() instead of [] when accessing the vector in the parsing loop in getSchedules() and we display a meaningful error message if we get the exceptiono