-
-
Notifications
You must be signed in to change notification settings - Fork 7
chore(deps): update error-prone monorepo to v2.42.0 #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
main
Choose a base branch
from
renovate/error-prone-monorepo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12872c7
to
61d6e69
Compare
e70b282
to
7cd4f6f
Compare
003dd9a
to
58a9ba0
Compare
58a9ba0
to
9f5fde8
Compare
7adaa06
to
9ef622b
Compare
9ef622b
to
a3f83b0
Compare
a3f83b0
to
c433228
Compare
c433228
to
83c3877
Compare
83c3877
to
aa9193e
Compare
aa9193e
to
517b51d
Compare
517b51d
to
db0a3b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.31.0
->2.42.0
2.31.0
->2.42.0
Release Notes
google/error-prone (com.google.errorprone:error_prone_annotations)
v2.42.0
: Error Prone 2.42.0Compare Source
New checks:
ExplicitArrayForVarargs
: discourage unnecessary explicit construction of an array to provide varargs.FloggerPerWithoutRateLimit
: discourage Flogger'sperUnique
without rate limitingStringJoin
: BanString.join(CharSequence)
andString.join(CharSequence, CharSequence)
ThreadBuilderNameWithPlaceholder
: Do not allow placeholders inThread.Builder.name(String)
orname(String, int)
.Changes:
ASTHelpers.asFlagSet
has changed. The previous type wasEnumSet<Flags.Flag>
, whereFlags.Flag
is an enum in the javac classFlags
. A recent JDK change has replaced that enum with a new top-level enum calledFlagsEnum
. It is not possible to changeASTHelpers.asFlagSet
in a way that would be type-safe and compatible with the enums from JDKs both before and after the change. Instead, the method now returnsImmutableSet<String>
, where the strings come from thetoString()
of the enum constants. That means they are"native"
,"abstract"
, etc.IO.print[ln]()
inSystemOut
.Full changelog: google/error-prone@v2.41.0...v2.42.0
v2.41.0
: Error Prone 2.41.0New checks:
public
orprotected
modifiers, but are effectively privateChanges:
Full changelog: google/error-prone@v2.40.0...v2.41.0
v2.40.0
: Error Prone 2.40.0Changes:
Full changelog: google/error-prone@v2.39.0...v2.40.0
v2.39.0
: Error Prone 2.39.0Changes:
Checks:
BooleanLiteral
: Prefertrue
toBoolean.TRUE
ExpensiveLenientFormatString
: Renamed fromPreconditionsExpensiveString
, detects unnecessary calls toString.format
in the arguments of lenient formatting methods.UnnecessaryQualifier
: Detects@Qualifier
or@BindingAnnotation
annotations that have no effect, and can be removedIssues: #4996, #5045
Full changelog: google/error-prone@v2.38.0...v2.39.0
v2.38.0
: Error Prone 2.38.0New checks:
AddNullMarkedToPackageInfo
: adds@org.jspecify.annotations.NullMarked
annotation to package-info filesIntLiteralCast
: Suggests a literal of the desired type instead of casting an int literal to a long, float, or doubleMisleadingEmptyVarargs
: Discourages calling varargs methods that expect at least one argument with no arguments, like Mockito'sthenThrow
PreconditionsExpensiveString
: Discourages expensive string formatting in GuavaPreconditions
checksSelfSet
: Detects mistakes likeproto.setFoo(proto.getFoo())
UnnecessaryCopy
: detect unnecessary copies of proto Lists and Maps.Closed issues: #4924, #4897, #4995
Full changelog: google/error-prone@v2.37.0...v2.38.0
v2.37.0
: Error Prone 2.37.0Changes:
error_prone_type_annotations
have been been merged intoerror_prone_annotations
.error_prone_type_annotations
is now deprecated, and will be removed in a future release.New checks:
AssignmentExpression
- The use of an assignment expression can be surprising and hard to read; consider factoring out the assignment to a separate statement.IntFloatConversion
- Detect calls toscalb
that should be using the double overload insteadInvalidSnippet
- Detects snippets which omit the:
required for inline code.JUnit4EmptyMethods
- Detects empty JUnit4@Before
,@After
,@BeforeClass
, and@AfterClass
methods.MockIllegalThrows
- Detects cases where Mockito is configured to throw checked exception types which are impossible.NegativeBoolean
- Prefer positive boolean names.RuleNotRun
- DetectsTestRule
s not annotated with@Rule
, that won't be run.StringConcatToTextBlock
- Replaces concatenated multiline strings with text blocks.TimeInStaticInitializer
- Detects accesses of the system time in static contexts.Closed issues:
@InlineMe
patching ofStrings.repeat
produces broken code (#4819)_
) variables (#4847)Full changelog: google/error-prone@v2.36.0...v2.37.0
v2.36.0
: Error Prone 2.36.0Changes:
ErrorProneScanner
for AST nodes introduced after Java 11 (e5fd194
)d67bc15
)--should-stop=ifError=FLOW
is set when using the-Xplugin
integration (e71db1f
)New checks:
DuplicateBranches
: Discourage conditional expressions and if statements where both branches are the sameRedundantControlFlow
: Reports redundantcontinue
statements.Closed issues: #4633, #4646
Full changelog: google/error-prone@v2.35.1...v2.36.0
v2.35.1
: Error Prone 2.35.1Error Prone's dependency on protobuf has been downgraded to 3.25.5 for this release.
Version 3.25.5 of protobuf still fixes CVE-2024-7254. This release is provided for users who aren't ready to update to 4.x, see also #4584 and #4634. Future versions of Error Prone will upgrade back to protobuf 4.x.
Full changelog: google/error-prone@v2.35.0...v2.35.1
v2.35.0
: Error Prone 2.35.0Changes:
\s
before the trailing delimiter inMisleadingEscapedSpace
TimeUnitMismatch
improvements: handle binary trees, consider trees likefooSeconds * 1000
to have units of millisNew checks:
JavaDurationGetSecondsToToSeconds
: Preferduration.toSeconds()
overduration.getSeconds()
Full changelog: google/error-prone@v2.34.0...v2.35.0
v2.34.0
: Error Prone 2.34.0Changes:
--should-stop=ifError=FLOW
is now required when running Error Prone (#4595)MemberName
check was renamed toIdentifierName
New checks:
FutureTransformAsync
: The usage of transformAsync is not necessary when all the return values of the transformation function are immediate futures.MisformattedTestData
: Reformats Java source code inside Error Prone test cases.MisleadingEscapedSpace
: Using\s
anywhere except at the end of a line in a text block is potentially misleading.ThrowIfUncheckedKnownUnchecked
:throwIfUnchecked(knownUnchecked)
is equivalent tothrow knownUnchecked
.Closed issues: #4595, #4598, #4620
Full changelog: google/error-prone@v2.33.0...v2.34.0
v2.33.0
: Error Prone 2.33.0Similar to release 2.32.0, the minimum supported JDK version to run Error Prone is JDK 17 (#3803). Using Error Prone to compile code that is deployed to earlier versions is still fully supported, but will require using JDK 17 or newer for compilation and setting
--release
or-source
/-target
/-bootclasspath
.Changes:
New checks:
ArrayRecordComponent
: Record components should not be arrays.Full changelog: google/error-prone@v2.32.0...v2.33.0
v2.32.0
: Error Prone 2.32.0The minimum support JDK version to run Error Prone is now JDK 17 (#3803).
Using Error Prone to compile code that is deployed to earlier versions is still fully supported, but will requires using JDK 17 or newer for compilation and setting
--release
or-source
/-target
/-bootclasspath
.Full changelog: google/error-prone@v2.31.0...v2.32.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.