add changeset auto generate job to workflow #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangwooseong
added
the
enhancement
🦋 Changeset detectedLatest commit: a61c7e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yangwooseong
changed the title
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
=======================================
Coverage 87.18% 87.18%
=======================================
Files 281 281
Lines 3903 3903
Branches 821 821
=======================================
Hits 3403 3403
Misses 425 425
Partials 75 75 ☔ View full report in Codecov by Sentry. |
yangwooseong
force-pushed
the
feat/add-changeset-generate-job
branch
from
bf98f52 to
eb8a2cc
Compare
yangwooseong
force-pushed
the
feat/add-changeset-generate-job
branch
from
eb8a2cc to
2ecbb5c
Compare
Chromatic Report🚀 Congratulations! Your build was successful! |
sungik-choi
reviewed
Oct 16, 2023
Comment on lines
10
to
12
| M: '**CHANGE**', | ||
| A: '**ADD**', | ||
| D: '**DELETE**', |
There was a problem hiding this comment.
마이너: 이 부분도 테이블과 같은 문구를 사용하면 더 일관적일 거 같아요! (대/소문자는 안 맞춰도 될 듯)
const statusByKey = {
M: 'modified',
A: 'added',
D: 'deleted',
}
sungik-choi
reviewed
Oct 16, 2023
| "@channel.io/bezier-icons": minor | ||
| --- | ||
|
|
||
| Icon Update |
sungik-choi
approved these changes
Oct 16, 2023
sungik-choi
pushed a commit
that referenced
this pull request
Oct 17, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/bezier-icons@0.14.0 ### Minor Changes - Update icons ([#1672](#1672)) by @Jamie-channel **ADD** - ai.svg - limit.svg - call-push-off-filled.svg - call-push-on-filled.svg **CHANGE** - goal-off.svg - goal.svg - Add changeset auto generating job to workflow ([#1676](#1676)) by @yangwooseong ## bezier-figma-plugin@0.4.6 ### Patch Changes - Updated dependencies - @channel.io/bezier-icons@0.14.0 - @channel.io/bezier-react@1.15.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yangwooseong
added
the
bezier-figma-plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
Related Issue
Fixes #863
Summary
Details
changeset 내부 코드를 보면, 파일의 경로와 확장자를 보고 파일이 changeset 인지를 확인하고, 파일안에 yaml front matter 가 있다면 거기서 version 을 파싱하고 있습니다. 따라서 changeset cli 를 통하지 않더라도, changeset이 기대하는 형태로 파일을 만든다면 인식이 잘 될 것으로 생각됩니다.
changeset 양식은 다음과 같습니다. 기존에 만들고 있는 형태를 유지했습니다.
Breaking change? (Yes/No)
References