Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Utils' from util module name #1754

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Nov 22, 2023

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Summary

유틸 함수 파일명에서 "Utils" 를 제거합니다. "utils" 디렉터리 내부에 있기 때문에, 불필요한 접미어라고 판단했습니다.

Breaking change? (Yes/No)

No

@sungik-choi sungik-choi added the refactoring Issue or PR related to refactoring with no functional changes label Nov 22, 2023
@sungik-choi sungik-choi self-assigned this Nov 22, 2023
Copy link

changeset-bot bot commented Nov 22, 2023

⚠️ No Changeset found

Latest commit: b97a765

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sungik-choi sungik-choi changed the title Refactor/utils Remove 'Utils' from util module name Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (410c21a) 87.45% compared to head (b97a765) 87.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1754   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files         281      281           
  Lines        3931     3931           
  Branches      822      822           
=======================================
  Hits         3438     3438           
  Misses        421      421           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi marked this pull request as ready for review November 23, 2023 06:02
@sungik-choi sungik-choi merged commit 3113117 into channel-io:main Nov 27, 2023
6 checks passed
@sungik-choi sungik-choi deleted the refactor/utils branch November 27, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Issue or PR related to refactoring with no functional changes
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants