Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bezier-react): add test code to assert #1770

Merged
merged 8 commits into from
Dec 7, 2023

Conversation

SEOKKAMONI
Copy link
Contributor

@SEOKKAMONI SEOKKAMONI commented Dec 1, 2023

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

add test code to assert

Details

image

Breaking change? (Yes/No)

References

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: d2954a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b76e0f) 87.47% compared to head (61db648) 87.70%.

❗ Current head 61db648 differs from pull request most recent head d2954a3. Consider uploading reports for the commit d2954a3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
+ Coverage   87.47%   87.70%   +0.23%     
==========================================
  Files         282      282              
  Lines        3959     3961       +2     
  Branches      826      826              
==========================================
+ Hits         3463     3474      +11     
+ Misses        424      415       -9     
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi added the test Issue or PR that related to test label Dec 4, 2023
Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @SEOKKAMONI 님, 우리 프로젝트에 보내주신 관심과 소중한 기여에 진심으로 감사드립니다 👍 앞으로도 더 많은 관심과 교류가 있기를 기대하며, 언제든 피드백이나 질문이 있으시면 GitHub Issue를 통해 편하게 말씀해주세요. 다시 한번 감사드립니다!

몇 가지 마이너한 코멘트 남겼으니, 확인해주시면 감사하겠습니다!

packages/bezier-react/src/utils/assert.test.ts Outdated Show resolved Hide resolved
packages/bezier-react/src/utils/assert.test.ts Outdated Show resolved Hide resolved
Co-authored-by: Ed <sungik.dev@gmail.com>
@yangwooseong yangwooseong self-requested a review December 4, 2023 08:29
@SEOKKAMONI
Copy link
Contributor Author

@sungik-choi @yangwooseong @Dogdriip isDev를 나중에 다른 파일에서도 쓰일 수 있다는 것을 고려한다면 따로 util로 빼는 것은 어떨까요? 의견 부탁드립니다!!

@sungik-choi
Copy link
Contributor

@sungik-choi @yangwooseong @Dogdriip isDev를 나중에 다른 파일에서도 쓰일 수 있다는 것을 고려한다면 따로 util로 빼는 것은 어떨까요? 의견 부탁드립니다!!

test/env.ts 로 분리하는 건 좋아보입니다.

@SEOKKAMONI
Copy link
Contributor Author

@sungik-choi @yangwooseong @Dogdriip isDev를 나중에 다른 파일에서도 쓰일 수 있다는 것을 고려한다면 따로 util로 빼는 것은 어떨까요? 의견 부탁드립니다!!

test/env.ts 로 분리하는 건 좋아보입니다.

당장에 문제는 없어보여서 해당 피알이 머지 된 후 따로 이슈를 파도록 하겠습니다 거기서 이야기하면 좋을 것 같아요!

@yangwooseong
Copy link
Collaborator

머지 하셔도 될 것 같습니다! 다른 pr 도 approve 받으셨다면 머지 해주셔도 됩니다

@SEOKKAMONI
Copy link
Contributor Author

머지 하셔도 될 것 같습니다! 다른 pr 도 approve 받으셨다면 머지 해주셔도 됩니다

감사합니다~ 제가 오너가 아니라 머지가 불가능하므로 머지 부탁드립니다!

@yangwooseong yangwooseong merged commit 678099a into channel-io:main Dec 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issue or PR that related to test
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants