Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for React 19 #2559

Merged
merged 19 commits into from
Dec 16, 2024
Merged

Support for React 19 #2559

merged 19 commits into from
Dec 16, 2024

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Dec 12, 2024

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

  • bezier-react를 React 19 버전으로 업데이트하고, 피어 디펜던시를 업데이트합니다. React 19 버전에서는 17 버전부터 도입된 새로운 JSX tranform을 사용하므로, 이를 지원하지 않는 16.8 버전에 대한 지원은 제거했습니다. 따라서 메이저 버전을 올립니다.
  • bezier-icons도 마찬가지로 React 19 버전으로 업데이트하고, 옵셔널 피어디펜던시로 React 17 버전 이상을 추가했습니다. bezier-icons는 svg만 사용할 수도 있으므로 옵셔널로 두었습니다.

Details

몇몇 개선사항들

  • bezier-react에 새로운 JSX transform을 사용합니다. 사용처에서 번들 사이즈 감소와 성능 향상이 있을 거로 예상합니다.
  • bezier-icons에 browserlist를 추가하여 불필요한 polyfill이 생기지 않도록 합니다. 원래 ai.mjs 파일에 objectSpread2 폴리필이 추가되어있었는데, 제거되었습니다. 마찬가지로 사용처에서 번들 사이즈 감소와 성능 향상이 있을 거로 예상합니다.
  • babel의 corejs 속성 등 불필요한 속성을 제거했습니다.

Breaking change? (Yes/No)

Yes. 더 이상 React 16.8 버전을 지원하지 않습니다.

References

@sungik-choi sungik-choi added enhancement Issues or PR related to making existing features better dependencies Pull requests that update a dependency file (Dependabot) labels Dec 12, 2024
@sungik-choi sungik-choi self-assigned this Dec 12, 2024
Copy link

channeltalk bot commented Dec 12, 2024

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: d2cc008

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@channel.io/bezier-react Major
@channel.io/bezier-icons Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sungik-choi
Copy link
Contributor Author

f2c2bd5 ~

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.95%. Comparing base (1583d42) to head (d2cc008).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nents/AlphaToggleButtonGroup/ToggleButtonGroup.tsx 0.00% 2 Missing ⚠️
.../bezier-react/src/components/ListItem/ListItem.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2559      +/-   ##
==========================================
- Coverage   81.96%   81.95%   -0.01%     
==========================================
  Files         143      143              
  Lines        3000     2871     -129     
  Branches      962      918      -44     
==========================================
- Hits         2459     2353     -106     
- Misses        510      514       +4     
+ Partials       31        4      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungik-choi sungik-choi merged commit bd59a67 into channel-io:main Dec 16, 2024
9 checks passed
@sungik-choi sungik-choi deleted the bump/react-19 branch December 16, 2024 05:33
sungik-choi pushed a commit that referenced this pull request Dec 16, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/bezier-react@3.0.0

### Major Changes

- Add support for React 19 and enable new JSX transform. Increase
minimum supported React peer dependency version from 16.8 to 17.
([#2559](#2559)) by
@sungik-choi

## @channel.io/bezier-icons@0.39.0

### Minor Changes

- Enable new JSX transform and update React peer dependency to be
optional for version 17 and above
([#2559](#2559)) by
@sungik-choi

## bezier-figma-plugin@0.6.20

### Patch Changes

-   Updated dependencies
    -   @channel.io/bezier-react@3.0.0
    -   @channel.io/bezier-icons@0.39.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file (Dependabot) enhancement Issues or PR related to making existing features better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for React v19
2 participants