-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Vue 3 and Nuxt 3 #265
Comments
@Chantouch i'm working on a vue 3 rewrite, just didn't get to write tests yet, gonna send a pull request asap.... Altho, it seems, sanitize-html doesn't work with Vite :( |
Lol, Thanks for working on it. Let see if sanitize-html can work with vite. 🍡 |
Can you create a draft PR for it? |
#284 added it, as well as sent a bug report for |
Any movement on this? We'd really like to use this package with our upcoming Nuxt 3 project. It looks like the issue I'm seeing is on line 55 of src/sanitize.ts, at least for our installation. Nuxt is throwing this error, when trying to set $sanitize on the Vue.prototype:
This may fix the issue:
|
@danluchs feel free to submit a PR for support nuxt 3, I will take a look on it. |
@chantouchsek I'm not sure about the PR process, it doesn't look like I can make a branch? The issue appears to be on line 55 in the
|
How did you try to create a branch? |
First fork it and commit from your repo |
OK, it's set up, ready for testing: |
@danluchs did you test on nuxt 3, I think it needs more change for that. |
So, does it support Vue 3 now or not? |
Haven't test on vue 3. |
Heya! Are you planning a tag released for vue 3?
The text was updated successfully, but these errors were encountered: