Rewrite v-sanitize into vue3/nuxt3

[truesteps]

Closed: #265

Hey!

I started working on the rewrite, couldn't test the directive yet, but the $sanitize function should already work. I ran into issues running sanitize-html under Vite. A possible solution would be to replace sanitize-html with dompurify.

Are you open to that idea, should I prototype up a rewrite with dompurify? You can check it our here https://github.com/cure53/DOMPurify

ToDo

• test directive in vue 3
• write tests
• test / update nuxt implementation for nuxt 3
• add typings extending vue
• fix compatibility issues with Vite and sanitize-html
• add editorconfig or eslint or any other form of keeping codestyle consistent

[chantouchsek]

Yes, it's nice, let go ahead try that to see if it works fine, we can release it for vue 3 and nuxt 3.

[chantouchsek]

But the another plugin already exist here: https://github.com/LeSuisse/vue-dompurify-html, so better avoid creating the same thing.

[truesteps]

@chantouchsek I use the package you linked as a replacement for v-sanitize, 'till I update the implementation :D. The problem with thatone is, that it only implements a directive, there is no sanitize function passed to the context as well as no native nuxt implementation.

[chantouchsek]

@chantouchsek I use the package you linked as a replacement for v-sanitize, 'till I update the implementation :D. The problem with thatone is, that it only implements a directive, there is no sanitize function passed to the context as well as no native nuxt implementation.

Ok, great 👍

[truesteps]

@chantouchsek heya! Please could you look into my tsconfig and sanitize.ts file? I am pretty new to TS and I don't know where in the documentation to look for stuff like extending vue or nuxt types so they include $sanitize and stuff like that, so I don't know where to add that in the nuxt3/vue3 version.

I added some basic tests for now and an example environment, where you can run the package in dev mode so you can test it properly without the need of another vue app.

Could you please checkut my version and maybe throw a PR with proper TS settings? After that I'd love to finish writing more tests and giving you the code for PR.

Thanks.

// Edit:

I'll make sure to make a better example in the future :D now it's just for testing while I update the package.
Btw I kept the sanitize-html, since the issue I mentioned seems to be an issue of PostCSS not sanitize-html

[chantouchsek]

@truesteps what editor/IDE are you using, that seem, you made to lots of files that doesn't related, can you check and revert all of the at first, then i will look up into it again. thanks.

[truesteps]

@chantouchsek I'm using phpstorm, I added a .editorconfig and reformated the entire project, feel free to modify the .editorconfig to your liking and I'll reformat it again :)

[truesteps]

The idea behind that came from the fact, that usually no 2 developers have the same formatting setup, so I added it to ensure all code will look the same in the future

[chantouchsek]

@truesteps no don't use phpstorm to write js or ts, you should use webstorm instead.

[truesteps]

@chantouchsek phpstorm is the same like webstorm, except it has support for PHP, nothing else is different. .editorconfig is supported by all editors not just the IntelliJ family of products from jetbrains

anyway, if you want me to rewert the formatting changes, I'll do that :)

[chantouchsek]

@chantouchsek phpstorm is the same like webstorm, except it has support for PHP, nothing else is different. .editorconfig is supported by all editors not just the IntelliJ family of products from jetbrains

anyway, if you want me to rewert the formatting changes, I'll do that :)

No, I don't accept that format.

[truesteps]

@chantouchsek phpstorm is the same like webstorm, except it has support for PHP, nothing else is different. .editorconfig is supported by all editors not just the IntelliJ family of products from jetbrains
anyway, if you want me to rewert the formatting changes, I'll do that :)

No, I don't accept that format.

what format do you wish to use? Please define it so I can implement it. Thanks

[chantouchsek]

@chantouchsek phpstorm is the same like webstorm, except it has support for PHP, nothing else is different. .editorconfig is supported by all editors not just the IntelliJ family of products from jetbrains
anyway, if you want me to rewert the formatting changes, I'll do that :)

No, I don't accept that format.

what format do you wish to use? Please define it so I can implement it. Thanks

Thanks, the current format is fine.