Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade backend dependencies #2641

Merged
merged 3 commits into from
Nov 29, 2023
Merged

chore: upgrade backend dependencies #2641

merged 3 commits into from
Nov 29, 2023

Conversation

atarashansky
Copy link
Contributor

@atarashansky atarashansky commented Nov 22, 2023

Reviewers

Functional:

Readability:


Changes

  • black changes
  • flake8 changes
  • miscellaneous fixes related to dependency upgrades
  • pandas still pinned to under 2.0 as 2.0 introduces a lot of breaking changes to many unit tests

Note:

  • I encourage reviewers to make pydist and pip install the distribution to test cellxgene locally. In my hands, i observed no regressions.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4bb9a2b) 0.00% compared to head (aa414bf) 70.52%.

❗ Current head aa414bf differs from pull request most recent head fc2511a. Consider uploading reports for the commit fc2511a to get more accurate results

Files Patch % Lines
server/common/annotations/local_file_csv.py 0.00% 2 Missing ⚠️
server/cli/annotate.py 0.00% 1 Missing ⚠️
server/common/genesets.py 0.00% 1 Missing ⚠️
server/common/rest.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2641       +/-   ##
=========================================
+ Coverage      0   70.52%   +70.52%     
=========================================
  Files         0       96       +96     
  Lines         0     6652     +6652     
  Branches      0      769      +769     
=========================================
+ Hits          0     4691     +4691     
- Misses        0     1885     +1885     
- Partials      0       76       +76     
Flag Coverage Δ
frontend 70.52% <79.16%> (?)
javascript 70.52% <79.16%> (?)
unitTest 70.52% <79.16%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atarashansky atarashansky requested a review from a team November 29, 2023 20:36
Copy link
Contributor

@atolopko-czi atolopko-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but didn't try make pydist as requested, so ignore my approval if that's a strongly recommended reviewer task.

@atarashansky atarashansky merged commit 6505f6c into main Nov 29, 2023
7 checks passed
@atarashansky atarashansky deleted the atar-fix-deps branch November 29, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants