Conversation
| "sds-caps-xxs": "18px", | ||
| "sds-caps-xxxs": "16px", | ||
| "sds-caps-xxxxs": "14px", | ||
| }, |
There was a problem hiding this comment.
It seems odd to have our template override the sds defaults. However, the documentation looks cramped without this.
tihuan
left a comment
tihuan
left a comment
There was a problem hiding this comment.
Thanks so much again for the PR, @ehoops-cz !
I just realized that since the tailwind implementation touches the whole app setup, I wonder if we should turn this repo into a monorepo with two templates, one for CSS in JS and the other for Tailwind?
This way we don't end up with a template that has both CSS in JS and Tailwind 😄
If that sounds good to you, maybe let's keep this PR as a draft for now, and I'll do some research to reorganize the repo accordingly and we can refactor this PR to work with the new repo structure 🙏
Thanks so much again for the template! Look forward to adding it to the repo 🎉 !!
| "react-dom": "^18", | ||
| "tailwind-merge": "^2.5.2", | ||
| "tailwindcss": "^3.4.10", | ||
| "webpack": "^5.94.0" |
There was a problem hiding this comment.
just curious, which packages require us to use webpack directly? I was hoping to keep it behind the scene and managed by Next.js 😆
source: https://nextjs.org/docs/app/api-reference/next-config-js/webpack
There was a problem hiding this comment.
@tihuan It's a peer dependency of @mdx-js/loader 😭
There was a problem hiding this comment.
@mdx-js/loader is part of the nextjs recommended mdx setup: https://nextjs.org/docs/pages/building-your-application/configuring/mdx
There was a problem hiding this comment.
Ooh I see! Thanks for the doc 💡 😄
Hmm maybe we still don't need to have webpack as direct dependency like Vercel's example here?
https://github.com/vercel/next.js/blob/canary/examples/with-mdx/package.json
2 participants
This PR adds:
Note - should I replace the example file content with lorem ipsum?