feat: Create Connection between Fed Server and Next Gen #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
routing based on feature flags
header
Co-authored-by: Jake Heath <76011913+jakeyheath@users.noreply.github.com>
…ion-server into CZID-8731
…deration-server into CZID-8731
Co-authored-by: Saquib Kothawala <saquib.kothawala@contractor.chanzuckerberg.com> Co-authored-by: Jerry Fu <2072627+jfoo1984@users.noreply.github.com> Co-authored-by: Jake Heath <76011913+jakeyheath@users.noreply.github.com> Co-authored-by: czi-github-helper[bot] <95879977+czi-github-helper[bot]@users.noreply.github.com> Co-authored-by: rzlim08 <37033997+rzlim08@users.noreply.github.com> Co-authored-by: bchu1 <151689101+bchu1@users.noreply.github.com> Co-authored-by: Suzette McCanny <smccanny@deloitte.ca> Co-authored-by: Erin Hoops <109251328+ehoops-cz@users.noreply.github.com>
rainandbare
changed the title
ehoops-cz
approved these changes
Mar 1, 2024
bchu1
reviewed
Mar 1, 2024
bchu1
reviewed
Mar 1, 2024
bchu1
reviewed
Mar 1, 2024
bchu1
reviewed
Mar 1, 2024
bchu1
reviewed
Mar 1, 2024
bchu1
reviewed
Mar 1, 2024
bchu1
approved these changes
Mar 1, 2024
jfoo1984
reviewed
Mar 1, 2024
jfoo1984
reviewed
Mar 1, 2024
|
|
||
| const checkForLogin = (responseUrl: string | null) => { | ||
| if (responseUrl?.includes("/auth0/refresh_token?mode=login")) { | ||
| throw new Error("You must be logged in to perform this action."); |
There was a problem hiding this comment.
In my experience, in mesh, if you throw an error and it isn't caught, it will kill the mesh process this code was running in (although it automatically attempts to restart it). Looking above, I believe this error should be caught and we reject the Promise, right? Just wanted to verify so we don't kill the server processes 😅
There was a problem hiding this comment.
Mmm yeah, this function has been there for a while but now that the functions are modular maybe I need try catch statements in the fetchFromNextGen and the getFromRails incase they are called on their own
jfoo1984
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
JIRA Ticket
CZID-8731
Description
This PR pulls in the connection code to main so that we are all synced up between sandbox and main.
This will allow us to work together on creating connections for individual resolvers.
There are a lot of formatting changes in this PR unfortunately but the main work is done in
httpUtils. I changed thegetfunction to receive an object and pulled outgetFromRailsandfetchFromNextGeninto their own functions so that we can call them directly in the resolvers if needed.We can either call
fetchFromNextGenusing the passed throughcontext.params.querywith a formatting function that pulls out the 'fed' prefix and theinput: {}wrapper or we can pass an optional custom query if we need something specific in the resolvers.Tests
Updated unit tests to cover new fedConsensusGenome functionality
Smoke tested with main branch of
czid-webto ensure no changes in functionality