fix: Fix semantic version errors in chart release process (#2732)

chanzuckerberg · Nov 16, 2023 · 0e84aa7 · 0e84aa7
1 parent ed50f36
commit 0e84aa7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/charts-release.yml b/.github/workflows/charts-release.yml
@@ -29,6 +29,12 @@ jobs:
     # NOTE: needs to be X64 because of helm-releaser
     runs-on: [ARM64, self-hosted, Linux]
     steps:
+      - name: Parse Version
+        id: parse_version
+        uses: actions/github-script@v5
+        with:
+          result-encoding: string
+          script: return context.ref.replace('refs/tags/happy-stack-helm-chart-v', '')
       - name: Generate token
         id: generate_token
         uses: chanzuckerberg/github-app-token@v1.1.4
@@ -96,8 +102,8 @@ jobs:
           
           
           RELEASE=${{ needs.check-chart-released.outputs.tag }}
-          VERSION=${RELEASE:1}
-          sed -i "s/0.0.0/$VERSION/g" ${CHARTS_DIR}/Chart.yaml
+          VERSION=${{ steps.parse_version.outputs.result }}
+          sed -i "\d+\.\d+\.\d+/$VERSION/g" ${CHARTS_DIR}/Chart.yaml
           echo ------
           cat ${CHARTS_DIR}/Chart.yaml
           echo ------

diff --git a/helm-charts/charts/stack/templates/_helpers.tpl b/helm-charts/charts/stack/templates/_helpers.tpl
@@ -112,4 +112,3 @@ Create the name of the service account to use
 {{- default "default" .Values.serviceAccount.name }}
 {{- end }}
 {{- end }}
-
Original file line number	Diff line number	Diff line change
Expand Up		@@ -112,4 +112,3 @@ Create the name of the service account to use
		{{- default "default" .Values.serviceAccount.name }}
		{{- end }}
		{{- end }}