Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add sameSite configuration to happy_sticky_session cookie #3819

Merged
merged 6 commits into from
Jan 30, 2025
Merged

feat: Add sameSite configuration to happy_sticky_session cookie #3819

merged 6 commits into from
Jan 30, 2025

Conversation

sfitzgerald-czi
Copy link
Collaborator

@sfitzgerald-czi sfitzgerald-czi commented Jan 30, 2025 •
edited by github-actions bot
Loading

CCIE-3976
Summary feat: SameSite cookie for happy_sticky_session
Type Task Task
Status In Progress

CCIE-3976

The configuration is optional with a default of "Lax"

Along needs this feature for sticky sessions when running in an iframe, configured as SameSite "None"

"Lax" is the default setting for all major browsers.

@sfitzgerald-czi
feat: AL-3844 Add sameSite configuration to happy_sticky_session cookie
7eb3b5d 
- configuration is optional with a default of "Lax"
@sfitzgerald-czi sfitzgerald-czi requested a review from a team as a code owner January 30, 2025 21:12
@github-actions GitHub Actions
Copy link
Contributor

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@sfitzgerald-czi sfitzgerald-czi changed the title feat: AL-3844 Add sameSite configuration to happy_sticky_session cookie feat: Add sameSite configuration to happy_sticky_session cookie Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@sfitzgerald-czi sfitzgerald-czi mentioned this pull request Jan 30, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@github-actions GitHub Actions
Copy link
Contributor

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@github-actions GitHub Actions
Copy link
Contributor

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@github-actions GitHub Actions
Copy link
Contributor

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@sfitzgerald-czi sfitzgerald-czi merged commit be3da49 into main Jan 30, 2025
35 checks passed
@sfitzgerald-czi sfitzgerald-czi deleted the sfitzgerald/add-samesite-sticky-session-cookie branch January 30, 2025 23:39
@czi-github-helper czi-github-helper bot mentioned this pull request Jan 29, 2025
Merged
@sfitzgerald-czi
Copy link
Collaborator Author

argus_sticky_session will also need SameSite None for Along CC: @hspitzley-czi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlokshin-czi alexlokshin-czi alexlokshin-czi approved these changes

@jakeyheath jakeyheath jakeyheath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfitzgerald-czi @jakeyheath @alexlokshin-czi