fix(tag): fix the type error for the hover prop of the tag component (#…

…353)
chanzuckerberg · Feb 14, 2023 · b9a3662 · b9a3662
1 parent f9844d3
commit b9a3662
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/src/core/Tag/index.stories.tsx b/src/core/Tag/index.stories.tsx
@@ -5,18 +5,9 @@ import Icon from "../Icon";
 import Tag from "./index";
 
 const Demo = (props: Args): JSX.Element => {
-  const { color, icon, label, sdsStyle, sdsType } = props;
+  const { label } = props;
 
-  return (
-    <Tag
-      color={color}
-      icon={icon}
-      label={label}
-      sdsStyle={sdsStyle}
-      sdsType={sdsType}
-      {...props}
-    />
-  );
+  return <Tag label={label} {...props} />;
 };
 
 const customColorTuples = {

diff --git a/src/core/Tag/style.ts b/src/core/Tag/style.ts
@@ -231,7 +231,7 @@ const typeToCss = {
   secondary,
 };
 
-const doNotForwardProps = ["sdsType", "sdsStyle", "tagColor"];
+const doNotForwardProps = ["sdsType", "sdsStyle", "tagColor", "hover"];
 
 export const StyledTag = styled(Chip, {
   shouldForwardProp: (prop) => !doNotForwardProps.includes(prop as string),