Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal button does not respect isAllCaps prop #832

Closed
ehoops-cz opened this issue Aug 21, 2024 · 0 comments · Fixed by #815
Closed

Minimal button does not respect isAllCaps prop #832

ehoops-cz opened this issue Aug 21, 2024 · 0 comments · Fixed by #815

Comments

@ehoops-cz
Copy link
Contributor

Describe the bug
Currently the minimal button always uses fontCapsXxxs, but this should default to not being all caps and only be all caps if isAllCaps === true.

code is here:

To Reproduce
Steps to reproduce the behavior:

        <Button
          sdsStyle="minimal"
          sdsType="primary"
          onClick={toggleExpandResponse}
          className="text-sds-body-s font-semibold"
        >
          {isResponseExpanded ? "Read Less" : "Read More"}
        </Button>

Expected behavior
Text should not be all caps, except when isAllCaps is passed in

Screenshots
Read More button here:
Screenshot 2024-08-20 at 3 44 49 PM

@ehoops-cz ehoops-cz assigned ehoops-cz and unassigned ehoops-cz Aug 21, 2024
@masoudmanson masoudmanson linked a pull request Aug 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant