feat(dark mode): Implementation #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MUI theme structure, storybook configs, color remaps BREAKING CHANGE: Style varibales have changed
masoudmanson
added
Ready for review
tihuan
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
LGTM! Thanks for implementing dark mode, @masoudmanson ❤️ Such an exciting feature 👏 !!
Since there's breaking changes from this PR, should we have a different ticket to provide some migration guide to ease with migration? And perhaps a ticket to update create-sds-app template to use the latest SDS too 🙆♂️
Thanks again for everything 🎉
… into 801-implement-dark-mode-plus-accessibility-color-updates
… into 801-implement-dark-mode-plus-accessibility-color-updates
… into 801-implement-dark-mode-plus-accessibility-color-updates
This was
linked to
issues
Aug 22, 2024
masoudmanson
deleted the
801-implement-dark-mode-plus-accessibility-color-updates
branch
masoudmanson
added
Released
and removed
Ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUI theme structure, storybook configs, color remaps
BREAKING CHANGE: Style varibales have changed
Old PR: #718
Summary
Structural Element (Base, Gene, DNA, Chromosome or Cell)
Github issue: #801