-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme): Update design tokens and defaultTheme #748
feat(theme): Update design tokens and defaultTheme #748
Conversation
…e Storybook sidebar hierarchy
…ailwinds formatter
…es into smaller files
Thanks for reviewing the code, @tihuan. 🎉😍 The latest commit organizes Storybook files and breaks down large Storybook files into smaller and manageable stories. Here is the general structure of each SDS component:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow your new file structure is a piece of art, @masoudmanson ! WE SHOULD FRAME IT 🤩 😆 🖼️ 🥇 👏
You're one of the best engineers I've had the honor to work with. Thanks so much for all the hard work 🙏
LGTM TO THE MAX!! 🚀
Thank you so much for your kind words! 🤩🥳😍🎉 I appreciate your support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so good, @masoudmanson !! Thanks for tackling so many changes! There are only two small things left to fix (font size on the section/column headers in DropdownMenu
and XMark
icon size on the TagFilter
) and then we should be good.
Awesome! 🥳🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @masoudmanson !! Thanks for the attention to detail getting all these changes implemented 💪
Summary
Design Tokens
Github issue: #747
Change List
Storybook
DefaultTheme and Design Tokens
All design tokens have been updated to the latest values based on the Figma Refactor outputs. Token names have been changed to reflect the new semantic structure. DefaultTheme has been created based on new design tokens, and it's ready to implement a multi-theme approach.
Component Styles
All components have been refactored and are now using the latest design tokens from the palette. All hardcoded spacings, colors, borders, etc., have been replaced with corresponding values from the theme Palette, making the whole design system dynamic and ready to use different theme files.
Icons
PascalCase
instead ofcamelCase
Updated Icon sizes for some components
Since the icons are a bit larger by default now, the s size chevron icon in some components has been replaced with xs size for better visuals.
Storybook Stories
Updated
intent
andcolor
propsThe accepted values for
intent
/color
props in SDS components has changed to semantic alternatesprimary
=>accent
info
=>info
error
=>negative
warning
=>notice
success
=>positive
beta
=>beta
Reworked components
Some SDS components have been reworked and bug-fixed.
InputCheckbox
,InputRadio
: Component structure has changed, and this bug (Update InputCheckbox and InputRadio to ensure correct text alignment #441) is resolved.InputToggle
InputSearch
: The search icon has been relocated to the left side of the input, and a new Clear icon has been added to the right side.SegmentedControl
Link
: TheLink
component now accepts two new props,sdsSize
andfontWeight
Tag
: Thecolor
prop is no longer required, and theTag
component will be rendered as a neutral tag if no colors are provided.CellBasic
: Introducing two additional properties to theCellBasic
component, enabling the inclusion of elements either to the right or at the bottom of the primary text (Add Component Slots to the BasicCell #758).