fix(gh-actions): remove need to run lint checks in container (#6287)

chanzuckerberg · Nov 30, 2023 · 9449220 · 9449220
1 parent 5eb9c8b
commit 9449220
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/.github/workflows/deploy-happy-stack.yml b/.github/workflows/deploy-happy-stack.yml
@@ -18,7 +18,7 @@ jobs:
     steps:
       - uses: actions/setup-node@v2
         with:
-          node-version: 15
+          node-version: "16.14.2"
       - name: Configure AWS Prod Credentials
         uses: aws-actions/configure-aws-credentials@v2
         if: github.event.deployment.environment == 'prod'

diff --git a/.github/workflows/push-tests.yml b/.github/workflows/push-tests.yml
@@ -39,12 +39,20 @@ jobs:
         with:
           fetch-depth: 2
       - uses: actions/setup-python@v3
+
       - name: check backend
         uses: pre-commit/action@v3.0.0
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: "frontend/.nvmrc"
+          cache: "npm"
+          cache-dependency-path: "frontend/package-lock.json"
       - name: check frontend
         run: |
-          cp frontend/src/configs/local.js frontend/src/configs/configs.js
-          docker-compose run --no-deps --rm frontend make lint
+          cd frontend
+          npm ci
+          cp src/configs/local.js src/configs/configs.js
+          npm run lint
       - uses: 8398a7/action-slack@v3
         with:
           status: ${{ job.status }}