Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cicd): Try to create rdev if happy update fails in PR #5798

Closed
wants to merge 2 commits into from
Closed

fix(cicd): Try to create rdev if happy update fails in PR #5798

wants to merge 2 commits into from

Conversation

Bento007
Copy link
Contributor

Reason for Change

  • #TICKET_NUMBER
  • There are cases where the rdev is not created when a PR is opened. Subsequent commits will fail to update the rdev because it doesn't exists. The deployment summary will never be applied because that happens when the PR is first opened. This ticket addresses these issues.

Changes

  • rename "create rdev" to "deploy rdev". This makes it easier to find in the list of GHA and describes both creation and update operations.
  • run happy create if happy update fails.
  • run happy update before create if the GHA event is synchronize.
  • Remove the requirement for Deployment summary If the rdev is not created when the PR is open the summary comment will not be added.

Testing steps

Notes for Reviewer

@Bento007
If create rdev get's skipped during PR creation and update fails, the…
62e0b35 
… rdev will be created

Signed-off-by: Trent Smith <trent.smith@chanzuckerberg.com>
@Bento007
use deploy happy defaults of create-or-update
62ba601 
Signed-off-by: Trent Smith <trent.smith@chanzuckerberg.com>
@Bento007 Bento007 closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Bento007